[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YCamNlCxK9nb8XrZ@smile.fi.intel.com>
Date: Fri, 12 Feb 2021 18:00:54 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v2 5/5] ACPI: property: Refactor
acpi_data_prop_read_single()
On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote:
> On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > Refactor acpi_data_prop_read_single() for less LOCs and better maintenance.
Thanks for review, my answers below.
...
> > + if (ret)
> > + return ret;
>
> else if (!val)
> ret = 1;
But then it become a bug again :-)
...
> And this is just not looking good to me, sorry.
Yeah, I think this patch is not needed right now. At least it seems no gain
from it.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists