linux-kernel - Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210212161305.GB19424@redhat.com>
Date:   Fri, 12 Feb 2021 11:13:05 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     Sergei Shtepa <sergei.shtepa@...am.com>
Cc:     Damien.LeMoal@....com, hare@...e.de, ming.lei@...hat.com,
        agk@...hat.com, corbet@....net, axboe@...nel.dk, jack@...e.cz,
        johannes.thumshirn@....com, gregkh@...uxfoundation.org,
        koct9i@...il.com, steve@....org, dm-devel@...hat.com,
        linux-block@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, pavel.tide@...am.com
Subject: Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD

On Tue, Feb 09 2021 at  9:30am -0500,
Sergei Shtepa <sergei.shtepa@...am.com> wrote:

> New ioctl DM_DEV_REMAP_CMD allow to remap bio requests
> from regular block device to dm device.

I really dislike the (ab)use of "REMAP" for this. DM is and always has
been about remapping IO.  Would prefer DM_DEV_INTERPOSE_CMD

Similarly, all places documenting "remap" or variables with "remap"
changed to "interpose".

Also, any chance you'd be open to putting all these interposer specific
changes in dm-interposer.[ch] ?
(the various internal structs for DM core _should_ be available via dm-core.h)

Mike