linux-kernel - Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210212124547.1dcf067e@gandalf.local.home>
Date:   Fri, 12 Feb 2021 12:45:47 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Xi Ruoyao <xry111@...gyan1223.wang>,
        "# 3.4.x" <stable@...r.kernel.org>,
        Arnd Bergmann <arnd@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Miroslav Benes <mbenes@...e.cz>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang
 non-section symbols

On Fri, 12 Feb 2021 11:07:50 -0600
Josh Poimboeuf <jpoimboe@...hat.com> wrote:


> > Any ideas are appreciated.  
> 
> [ Adding Steve Rostedt ]
> 
> This error message comes from recordmcount.  It probably can't handle
> the missing STT_SECTION symbols which are getting stripped by the new
> binutils.  (Objtool also had trouble with that.)
> 
> No idea why you only see this on 4.4 though.
> 

Just taking a quick look, but would something like this work?

I created this against v4.4.257.

-- Steve

diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index 04151ede8043..698404f092d0 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -437,6 +437,8 @@ static unsigned find_secsym_ndx(unsigned const txtndx,
 			if (w2(ehdr->e_machine) == EM_ARM
 			    && ELF_ST_TYPE(symp->st_info) == STT_FUNC)
 				continue;
+			if (ELF_ST_TYPE(symp->st_info) == STT_SECTION)
+				continue;
 
 			*recvalp = _w(symp->st_value);
 			return symp - sym0;