linux-kernel - Re: [PATCH] x86: entry: Remove _TIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 Feb 2021 20:19:13 +0100
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Kyle Huey <me@...ehuey.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Gabriel Krisman Bertazi <krisman@...labora.com>,
        Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...nel.org>,
        Frederic Weisbecker <frederic@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Jens Axboe <axboe@...nel.dk>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: entry: Remove _TIF_SINGLESTEP define leftover

On Mon, Feb 8, 2021 at 11:01 PM Kyle Huey <me@...ehuey.com> wrote:
>
> Looks good to me.
>

Any other comments on this patch v2?

Thanks.

- Sedat -

> - Kyle
>
> On Mon, Feb 8, 2021 at 1:43 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> >
> > After commit 6342adcaa683 ("entry: Ensure trap after single-step on
> > system call return") a _TIF_SINGLESTEP define is obsolete for arch/x86.
> >
> > So, remove the leftover in arch/x86/include/asm/thread_info.h file.
> >
> > Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return"
> > CC: Kyle Huey <me@...ehuey.com>
> > Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>
> > ---
> >  arch/x86/include/asm/thread_info.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> > index 0d751d5da702..8861967e0305 100644
> > --- a/arch/x86/include/asm/thread_info.h
> > +++ b/arch/x86/include/asm/thread_info.h
> > @@ -101,7 +101,6 @@ struct thread_info {
> >  #define _TIF_NOTIFY_RESUME     (1 << TIF_NOTIFY_RESUME)
> >  #define _TIF_SIGPENDING                (1 << TIF_SIGPENDING)
> >  #define _TIF_NEED_RESCHED      (1 << TIF_NEED_RESCHED)
> > -#define _TIF_SINGLESTEP                (1 << TIF_SINGLESTEP)
> >  #define _TIF_SSBD              (1 << TIF_SSBD)
> >  #define _TIF_SPEC_IB           (1 << TIF_SPEC_IB)
> >  #define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE)
> > --
> > 2.30.0
> >