lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 14 Feb 2021 02:46:07 +0000
From:   Geethasowjanya Akula <>
To:     "Gustavo A. R. Silva" <>,
        Sunil Kovvuri Goutham <>,
        Linu Cherian <>,
        "Jerin Jacob Kollanukkaran" <>,
        Hariprasad Kelam <>,
        Subbaraya Sundeep Bhatta <>,
        "David S. Miller" <>,
        Jakub Kicinski <>
CC:     "" <>,
        "" <>
Subject: Re: [EXT] [bug report] octeontx2-af: cn10k: Identical code for
 different branches

Hi Gustavo,

Please see inline.

>From: Gustavo A. R. Silva <>
>Sent: Saturday, February 13, 2021 1:31 AM
>To: Sunil Kovvuri Goutham; Linu Cherian; Geethasowjanya Akula; Jerin Jacob >Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; David S. Miller; Jakub >Kicinski
>Cc:;; Gustavo A. R. Silva
>Subject: [EXT] [bug report] octeontx2-af: cn10k: Identical code for different branches

>External Email


>In file drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c, function rvu_dbg_init()
>the same code is executed for both branches:

>2431         if (is_rvu_otx2(rvu))
>2432                 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
>2433                                     rvu, &rvu_dbg_rvu_pf_cgx_map_fops);
>2434         else
>2435                 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
>2436                                     rvu, &rvu_dbg_rvu_pf_cgx_map_fops);

>This issue was introduced by commit 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM >MAC support")

>What's the right solution for this?
Thanks Gustavo for pointing out.  below is the right cod for else conduction.

      debugfs_create_file("rvu_pf_rpm_map", 0444, rvu->rvu_dbg.root,
                                    rvu, &rvu_dbg_rvu_pf_cgx_map_fops);


Powered by blists - more mailing lists