lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <877dnbrxka.fsf@codeaurora.org> Date: Sun, 14 Feb 2021 08:08:21 +0200 From: Kalle Valo <kvalo@...eaurora.org> To: Shuah Khan <skhan@...uxfoundation.org> Cc: peterz@...radead.org, mingo@...hat.com, will@...nel.org, davem@...emloft.net, kuba@...nel.org, ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] ath10k: detect conf_mutex held ath10k_drain_tx() calls Shuah Khan <skhan@...uxfoundation.org> writes: > ath10k_drain_tx() must not be called with conf_mutex held as workers can > use that also. Add call to lockdep_assert_not_held() on conf_mutex to > detect if conf_mutex is held by the caller. > > The idea for this patch stemmed from coming across the comment block > above the ath10k_drain_tx() while reviewing the conf_mutex holds during > to debug the conf_mutex lock assert in ath10k_debug_fw_stats_request(). > > Adding detection to assert on conf_mutex hold will help detect incorrect > usages that could lead to locking problems when async worker routines try > to call this routine. > > Link: https://lore.kernel.org/linux-wireless/871rdmu9z9.fsf@codeaurora.org/ > Signed-off-by: Shuah Khan <skhan@...uxfoundation.org> This can go via the same tree as patch 1: Acked-by: Kalle Valo <kvalo@...eaurora.org> But I can also take this to my ath tree, once patch 1 has reached it. Just let me know what is preferred. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists