lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 13 Feb 2021 23:05:56 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     AristoChen <jj251510319013@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix typo in f_printer.c

On 2/13/21 10:53 PM, AristoChen wrote:
> In line 824, it is trying to open `out_ep`, so
> I believe in line 826, it should print `out_ep`
> instead of `in_ep`
> 
> Signed-off-by: AristoChen <jj251510319013@...il.com>
> ---
>   drivers/usb/gadget/function/f_printer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
> index 2f1eb2e81d30..a3b17ec00bf0 100644
> --- a/drivers/usb/gadget/function/f_printer.c
> +++ b/drivers/usb/gadget/function/f_printer.c
> @@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)
>   
>   	result = usb_ep_enable(dev->out_ep);
>   	if (result != 0) {
> -		DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
> +		DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
>   		goto done;
>   	}
>   
> 

Hi,
The patch makes sense.
You should Cc: the USB gadget maintainer and the linux-usb mailing list.

Thanks.

Powered by blists - more mailing lists