linux-kernel - Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YCjdjdjcdXRUMhU/@kroah.com>
Date:   Sun, 14 Feb 2021 09:21:33 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Thais Camacho <thaiscamachoo@...il.com>
Cc:     devel@...verdev.osuosl.org, Todd Kjos <tkjos@...roid.com>,
        linux-kernel@...r.kernel.org, Hridya Valsaraju <hridya@...gle.com>,
        Arve Hjønnevåg <arve@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Martijn Coenen <maco@...roid.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Christian Brauner <christian@...uner.io>
Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with
 const keyword

On Sat, Feb 13, 2021 at 11:31:36PM -0300, Thais Camacho wrote:
> Warning found by checkpatch.pl script
> 
> Signed-off-by: Thais Camacho <thaiscamachoo@...il.com>
> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 4789d36ddfd3..2cb665e0228c 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>  
>  static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	static struct file_operations vmfile_fops;
> +	static const struct file_operations vmfile_fops;
>  	struct ashmem_area *asma = file->private_data;
>  	int ret = 0;
>  
> -- 
> 2.20.1

Any specific reason why you did not test-build your change before
sending it to us?  Please always do so, otherwise it causes lots of
problems, and makes maintainers grumpy :)

thanks,

greg k-h