linux-kernel - Re: [PATCH] iio: adc: adi-axi-adc: add proper Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210214124042.527bcfce@archlinux>
Date:   Sun, 14 Feb 2021 12:40:42 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <michael.hennerich@...log.com>
Subject: Re: [PATCH] iio: adc: adi-axi-adc: add proper Kconfig dependencies

On Wed, 10 Feb 2021 12:50:44 +0200
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> The ADI AXI ADC driver requires IO mem access and OF to work. This change
> adds these dependencies to the Kconfig symbol of the driver.
> 
> This was also found via the lkp bot, as the
> devm_platform_ioremap_resource() symbol was not found at link-time on the
> S390 architecture.
> 
> Fixes: ef04070692a21 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 769381b05b9a..d20a3b574af9 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -266,6 +266,8 @@ config ADI_AXI_ADC
>  	select IIO_BUFFER
>  	select IIO_BUFFER_HW_CONSUMER
>  	select IIO_BUFFER_DMAENGINE
> +	depends on HAS_IOMEM
> +	depends on OF
>  	help
>  	  Say yes here to build support for Analog Devices Generic
>  	  AXI ADC IP core. The IP core is used for interfacing with