linux-kernel - Re: [PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210215.125733.311587463365048945.davem@davemloft.net>
Date:   Mon, 15 Feb 2021 12:57:33 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     sgoutham@...vell.com, cjacob@...vell.com, gakula@...vell.com,
        sbhatta@...vell.com, hkelam@...vell.com, kuba@...nel.org,
        jesse.brandeburg@...el.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] octeontx2-pf: fix an off by one bug in
 otx2_get_fecparam()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Mon, 15 Feb 2021 18:56:46 +0300

> The "<= FEC_MAX_INDEX" comparison should be "< FEC_MAX_INDEX".
> 
> I did some cleanup in this function to hopefully make the code a bit
> clearer.  There was no blank line after the declaration block.  The
> closing curly brace on the fec[] declaration normally goes on a line
> by itself.  And I removed the FEC_MAX_INDEX define and used
> ARRAY_SIZE(fec) instead.
> 
> Fixes: d0cf9503e908 ("octeontx2-pf: ethtool fec mode support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

This doesn't apply to net-next.