linux-kernel - Re: [greybus-dev] [PATCH 1/1] staging: greybus: Added do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210215105202.GA2087@kadam>
Date:   Mon, 15 Feb 2021 13:52:02 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        elder@...nel.org, linux-kernel@...r.kernel.org, johan@...nel.org,
        greybus-dev@...ts.linaro.org,
        Hemansh Agnihotri <hemanshagnihotri27@...il.com>
Subject: Re: [greybus-dev] [PATCH 1/1] staging: greybus: Added do - while in
 multi statement macro

On Thu, Feb 11, 2021 at 03:40:39PM +0530, Viresh Kumar wrote:
> On 11-02-21, 11:00, Greg KH wrote:
> > On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote:
> > > This patch add fixes an checkpatch error for "Macros with multiple statements
> > > should be enclosed in a do - while loop"
> > > 
> > > Signed-off-by: Hemansh Agnihotri <hemanshagnihotri27@...il.com>
> > 
> > Any reason you didn't test-build your patch before sending it out?
> > 
> > That's a bit rude to reviewers :(
> 
> I also wonder how two people stumbled upon the exact same thing at the
> same time. Copy/paste ?
> 

Those things are pretty common where people try to fix the first
checkpatch warning they find.  There was one time some years back when 5
people sent the same patch.

regards,
dan carpenter