linux-kernel - Re: [PATCH] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202102151045.M1uYWT2U-lkp@intel.com>
Date:   Mon, 15 Feb 2021 10:56:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Don Bollinger <don@...bollingers.org>, arndb@...db.de,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, brandon_chuang@...e-core.com,
        wally_wang@...ton.com, aken_liu@...e-core.com, gulv@...rosoft.com,
        jolevequ@...rosoft.com, xinxliu@...rosoft.com,
        Don Bollinger <don@...bollingers.org>
Subject: Re: [PATCH] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

Hi Don,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c]

url:    https://github.com/0day-ci/linux/commits/Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
base:   a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c
config: sparc64-randconfig-p002-20210215 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9089aa757bfb70c473ca54face762582908bdd28
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
        git checkout 9089aa757bfb70c473ca54face762582908bdd28
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/eeprom/optoe.c:615:16: warning: no previous prototype for 'optoe_make_regmap' [-Wmissing-prototypes]
     615 | struct regmap *optoe_make_regmap(struct i2c_client *client)
         |                ^~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for COMPAT_BINFMT_ELF
   Depends on COMPAT && BINFMT_ELF
   Selected by
   - COMPAT && SPARC64


vim +/optoe_make_regmap +615 drivers/misc/eeprom/optoe.c

   605	
   606	
   607	/*
   608	 * optoe_make_regmap creates the regmap for the client.
   609	 * IMPORTANT: Don't call the regmap read/write calls directly
   610	 * for these devices.  These devices are paged, and you have to
   611	 * set the page register before accessing the data in that page.
   612	 * Use the nvmem interfaces, those read/write calls use this
   613	 * driver to manage pages correctly.
   614	 */
 > 615	struct regmap *optoe_make_regmap(struct i2c_client *client)
   616	{
   617		struct regmap_config regmap_config = { };
   618		struct regmap *regmap;
   619	
   620		/* setup a minimal regmap - 8 bits, 8 bit addresses */
   621		regmap_config.val_bits = 8;
   622		regmap_config.reg_bits = 8;
   623	
   624		/* I'll handle the locking */
   625		regmap_config.disable_locking = true;
   626		regmap = devm_regmap_init_i2c(client, &regmap_config);
   627		return regmap;
   628	}
   629	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30773 bytes)