linux-kernel - [PATCH] perf annotate: do not jump after 'k' is pressed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <65416cff-4eb6-713c-a174-2aa43fa64332@suse.cz>
Date:   Mon, 15 Feb 2021 13:45:25 +0100
From:   Martin Liška <mliska@...e.cz>
To:     linux-kernel@...r.kernel.org
Cc:     linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: [PATCH] perf annotate: do not jump after 'k' is pressed

Do not jump when 'k' is pressed, the cursor show stay where it is.
Right now, it jumps to the currently selected hot instruction.

Signed-off-by: Martin Liška <mliska@...e.cz>
---
  tools/perf/ui/browsers/annotate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index bd77825fd5a1..35b82caf8090 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -759,7 +759,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
  			continue;
  		case 'k':
  			notes->options->show_linenr = !notes->options->show_linenr;
-			break;
+			continue;
  		case 'H':
  			nd = browser->curr_hot;
  			break;
-- 
2.30.0