linux-kernel - Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCp1KL/+YYxmr7vO@smile.fi.intel.com>
Date:   Mon, 15 Feb 2021 15:20:40 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        wsa@...nel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH i2c-next] i2c: designware: Consolidate
 pci_free_irq_vectors to a single place

On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote:
> Consolidate pci_free_irq_vectors to a single place using "goto free_irq"
> for simplify the code.

One nit below, after addressing:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

...

> +free_irq:

It's quite confusing name. I would expect to see here (with current proposal)
*free_irq() call, but no, I don't see a such.

Please, change to something like
	err_pci_free_irq_vectors:
or alternatively
	err_free_irq_vectors:
however I think first one is disambiguous.

> +	pci_free_irq_vectors(pdev);
> +	return r;

-- 
With Best Regards,
Andy Shevchenko