linux-kernel - Re: [PATCH 1/3] dmaengine: hsu: Add missing call to 'pci_free_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Feb 2021 15:25:46 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Vinod Koul <vkoul@...nel.org>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        Ferry Toth <ftoth@...londelft.nl>, qiuzhenfa@...ilicon.com,
        dmaengine <dmaengine@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] dmaengine: hsu: Add missing call to
 'pci_free_irq_vectors()' in probe and remove functions

On Sun, Feb 14, 2021 at 3:22 PM Dejin Zheng <zhengdejin5@...il.com> wrote:
>
> Call to 'pci_free_irq_vectors()' are missing both in the error handling
> path of the probe function, and in the remove function.
> Add them.

> Fixes: e9bb8a9df316a2 ("dmaengine: hsu: pci: switch to new API for IRQ allocation")

Same as per others. This does not fix anything, because there is no issue.
If you want to have it better, introduce a pcim_alloc_irq_vectors() to
show that it's managed.


-- 
With Best Regards,
Andy Shevchenko