linux-kernel - Re: [PATCH] pinctrl: stm32: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6d7ad2ea-92dc-3caa-a931-2c932325a46b@foss.st.com>
Date:   Mon, 15 Feb 2021 14:56:56 +0100
From:   foss <fabien.dessenne@...s.st.com>
To:     <angkery@....com>, <linus.walleij@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE-SCND-02 <alexandre.torgue@...s.st.com>,
        <maz@...nel.org>,
        Etienne CARRIERE-SCND-01 <etienne.carriere@...s.st.com>,
        <geert+renesas@...der.be>, <matti.vaittinen@...rohmeurope.com>,
        <marex@...x.de>
CC:     <linux-gpio@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        <yangjunlin@...ong.com>
Subject: Re: [PATCH] pinctrl: stm32: add missing of_node_put

Resending in plain-text format.


On 15/02/2021 2:26 pm, foss wrote:
>
> Hi Junlin
>
>
> Thank you for the patch!
>
>
> Fabien
>
>
>> From: Junlin Yang<yangjunlin@...ong.com>
>>
>> Fix OF node leaks by calling of_node_put in for_each_available_child_of_node when the cycle returns.
>>
>> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>>
>> Signed-off-by: Junlin Yang<yangjunlin@...ong.com>
>
> Acked-by: Fabien Dessenne <fabien.dessenne@...s.st.com>
>
>
>> ---
>>   drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
>> index 7d9bded..da72e3e 100644
>> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c
>> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
>> @@ -1542,8 +1542,10 @@ int stm32_pctl_probe(struct platform_device *pdev)
>>   		if (of_property_read_bool(child, "gpio-controller")) {
>>   			bank->rstc = of_reset_control_get_exclusive(child,
>>   								    NULL);
>> -			if (PTR_ERR(bank->rstc) == -EPROBE_DEFER)
>> +			if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) {
>> +				of_node_put(child);
>>   				return -EPROBE_DEFER;
>> +			}
>>   
>>   			bank->clk = of_clk_get_by_name(child, NULL);
>>   			if (IS_ERR(bank->clk)) {
>> @@ -1551,6 +1553,7 @@ int stm32_pctl_probe(struct platform_device *pdev)
>>   					dev_err(dev,
>>   						"failed to get clk (%ld)\n",
>>   						PTR_ERR(bank->clk));
>> +				of_node_put(child);
>>   				return PTR_ERR(bank->clk);
>>   			}
>>   			i++;
>> --
>> 1.9.1
>>