linux-kernel - Re: [PATCH] bus: mhi: core: Use current ee in intvec handler for syserr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi_xpDmGRWP7TObR-Sj45pAiUK9YXoSXQgEnfoL6YQy4Fw@mail.gmail.com>
Date:   Mon, 15 Feb 2021 08:21:46 +0100
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Jeffrey Hugo <jhugo@...eaurora.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Hemant Kumar <hemantk@...eaurora.org>,
        Bhaumik Bhatt <bbhatt@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bus: mhi: core: Use current ee in intvec handler for syserr

On Sat, 13 Feb 2021 at 01:41, Jeffrey Hugo <jhugo@...eaurora.org> wrote:
>
> The intvec handler stores the caches ee in a local variable for use in
> processing the intvec.  When determining if a syserr is a fatal error or
> not, the intvec handler is using the cached version, when it should be
> using the current ee read from the device.  Currently, the device could
> be in the PBL ee as the result of a fatal error, but the cached ee might
> be AMSS, which would cause the intvec handler to incorrectly signal a
> non-fatal syserr.
>
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>

So in that function, 'ee' should be 'previous_ee', right?

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>