linux-kernel - Re: [patch V2 13/13] x86/softirq/64: Inline do_softirq_own

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210215163939.GA144191@roeck-us.net>
Date:   Mon, 15 Feb 2021 08:39:39 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Helge Deller <deller@....de>,
        "David S. Miller" <davem@...emloft.net>,
        Michael Ellerman <mpe@...erman.id.au>,
        Rich Felker <dalias@...c.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Kees Cook <keescook@...omium.org>,
        Lai Jiangshan <jiangshanlai+lkml@...il.com>
Subject: Re: [patch V2 13/13] x86/softirq/64: Inline do_softirq_own_stack()

On Wed, Feb 10, 2021 at 12:40:54AM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> There is no reason to have this as a seperate function for a single caller.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Reviewed-by: Kees Cook <keescook@...omium.org>

When building ARCH=um SUBARCH="x86_64" defconfig:

kernel/softirq.c: In function 'invoke_softirq':
arch/x86/include/asm/irq_stack.h:199:19: error: 'hardirq_stack_inuse' undeclared

./arch/x86/include/asm/irq_stack.h:84:33: error: ‘hardirq_stack_ptr’ undeclared (first use in this function)

Guenter

---
bisect log:

# bad: [52a0bcb60e40f30211cb5cbbb0f582ec4e91d896] Add linux-next specific files for 20210215
# good: [92bf22614b21a2706f4993b278017e437f7785b3] Linux 5.11-rc7
git bisect start 'HEAD' 'v5.11-rc7'
# good: [9f44811a4ca6db01e73017e565381549b3c3fc60] next-20210212/mtd
git bisect good 9f44811a4ca6db01e73017e565381549b3c3fc60
# good: [88a516b8c681d666e252abfa5e346606d94653a3] Merge remote-tracking branch 'devicetree/for-next'
git bisect good 88a516b8c681d666e252abfa5e346606d94653a3
# bad: [1c623c776046c4b9d47f70f07928980815578cc1] Merge remote-tracking branch 'char-misc/char-misc-next'
git bisect bad 1c623c776046c4b9d47f70f07928980815578cc1
# bad: [f70ed845051885a4887dd76cb7c616b8f4a2942c] Merge remote-tracking branch 'drivers-x86/for-next'
git bisect bad f70ed845051885a4887dd76cb7c616b8f4a2942c
# bad: [f1b61f7b4fb971f281978fb905507e9ac9b2d973] Merge branch 'core/mm'
git bisect bad f1b61f7b4fb971f281978fb905507e9ac9b2d973
# bad: [364af1939d1ec3512b69bcdc035063a60f9c0b3e] Merge branch 'ras/core'
git bisect bad 364af1939d1ec3512b69bcdc035063a60f9c0b3e
# bad: [9db733e3c78c9c00fa93860078674f23d6dd8b7d] Merge branch 'x86/entry'
git bisect bad 9db733e3c78c9c00fa93860078674f23d6dd8b7d
# bad: [a3251c1a36f595046bea03935ebe37a1e1f1f1d7] Merge branch 'x86/paravirt' into x86/entry
git bisect bad a3251c1a36f595046bea03935ebe37a1e1f1f1d7
# good: [f83d1a0190bf6ac788a848454d21daee2299d085] x86/acpi: Annotate indirect branch as safe
git bisect good f83d1a0190bf6ac788a848454d21daee2299d085
# good: [a0cfc74d0b00c5201e1c09e28b2dc01c8088f809] x86/irq: Provide macro for inlining irq stack switching
git bisect good a0cfc74d0b00c5201e1c09e28b2dc01c8088f809
# good: [db1cc7aede37eb9235759131ddfefd9c0ea5136f] softirq: Move do_softirq_own_stack() to generic asm header
git bisect good db1cc7aede37eb9235759131ddfefd9c0ea5136f
# good: [53c9d9240944088274aadbbbafc6138ca462db4f] x86/pv: Switch SWAPGS to ALTERNATIVE
git bisect good 53c9d9240944088274aadbbbafc6138ca462db4f
# good: [ab234a260b1f625b26cbefa93ca365b0ae66df33] x86/pv: Rework arch_local_irq_restore() to not use popf
git bisect good ab234a260b1f625b26cbefa93ca365b0ae66df33
# bad: [72f40a2823d6e16229ab58b898c6f22044e5222f] x86/softirq/64: Inline do_softirq_own_stack()
git bisect bad 72f40a2823d6e16229ab58b898c6f22044e5222f
# first bad commit: [72f40a2823d6e16229ab58b898c6f22044e5222f] x86/softirq/64: Inline do_softirq_own_stack()