linux-kernel - Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210216075530.knleci6sv4m667vv@gilmour>
Date:   Tue, 16 Feb 2021 08:55:30 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        dave.stevenson@...pberrypi.com, maz@...nel.org, eric@...olt.net,
        tzimmermann@...e.de, linux-rpi-kernel@...ts.infradead.org,
        hverkuil-cisco@...all.nl, nsaenzjulienne@...e.de,
        mchehab@...nel.org, linux-media@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        dri-devel@...ts.freedesktop.org, Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt
 controller"

On Fri, Feb 12, 2021 at 11:11:04AM -0800, Florian Fainelli wrote:
> As Dave reported:
> 
> This seems to have unintended side effects.  GIC interrupt 117 is shared
> between the standard I2C controllers (i2c-bcm2835) and the l2-intc block
> handling the HDMI I2C interrupts.
> 
> There is not a great way to share an interrupt between an interrupt
> controller using the chained IRQ handler which is an interrupt flow and
> another driver like i2c-bcm2835 which uses an interrupt handler
> (although it specifies IRQF_SHARED).
> 
> Simply revert this change for now which will mean that HDMI I2C will be
> polled, like it was before.
> 
> Reported-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)