linux-kernel - Re: [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <337123b0-b2af-a522-3dfe-fd1098a0cad9@redhat.com>
Date:   Tue, 16 Feb 2021 10:04:27 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Anshuman Khandual <anshuman.khandual@....com>, linux-mm@...ck.org,
        linux-arm-kernel@...ts.infradead.org, catalin.marinas@....com,
        akpm@...ux-foundation.org, will@...nel.org
Cc:     Robin Murphy <robin.murphy@....com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Christoph Hellwig <hch@....de>,
        Mark Rutland <mark.rutland@....com>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] mm/page_alloc: Fix pageblock_order with
 HUGETLB_PAGE_SIZE_VARIABLE

>>
>>
>> But again, if there are valid use cases then sure, let's make the code fully compatible with HUGETLB_PAGE_ORDER > MAX_ORDER.
> 
> Given that gigantic HugeTLB allocation can fallback on alloc_contig_pages()
> or CMA if/when available, is there a real need for HUGETLB_PAGE_ORDER to be
> upto MAX_ORDER, used as pageblock_order or as COMPACTION_HPAGE_ORDER ? With
> gigantic HugeTLB pages being available, HUGETLB_PAGE_ORDER seems to be just
> detached from the buddy allocator. But I am not sure, will keep looking.

Having HPAGE_PMD_ORDER >>= MAX_ORDER ("significantly larger") will make 
it very unlikely that you are able to reliably allocate any huge pages 
at all dynamically at runtime without CMA.

Gigantic pages are problematic by nature :)

-- 
Thanks,

David / dhildenb