linux-kernel - Re: [PATCH v2] fs: ubifs: set s_uuid in super block to support ima/evm uuid options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Feb 2021 11:11:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Juergen Borleis <jbe@...gutronix.de>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Richard Weinberger <richard@....at>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:MEMORY TECHNOLOGY..." <linux-mtd@...ts.infradead.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Steffen Trumtrar <s.trumtrar@...gutronix.de>,
        Oleksij Rempel <o.rempel@...gutronix.de>
Subject: Re: [PATCH v2] fs: ubifs: set s_uuid in super block to support
 ima/evm uuid options

+Cc: Stephen

Stephen, do you have a check in Linux Next to catch the problem that
Co-developed-by is not being accompanied by a corresponding SoB?

On Tue, Feb 16, 2021 at 11:09 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@...gutronix.de> wrote:
> >
> > From: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> >
> > This is required to provide uuid based integrity functionality for:
> > ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option).
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> One issue below has to be addressed nevertheless.
>
> > Co-developed-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > Co-developed-by: Juergen Borleis <jbe@...gutronix.de>
>
> According to the documentation [1] above has two issues:
> - all Co-developed-by *must* be accompanied with corresponding SoBs
> - commiter must provide his SoB (but it will be implied by the
> previous requirement in this case)
>
> [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
>
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> > ---
> >  fs/ubifs/super.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> > index 138b9426c6c1..a8383ca39a47 100644
> > --- a/fs/ubifs/super.c
> > +++ b/fs/ubifs/super.c
> > @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)
> >                 goto out_umount;
> >         }
> >
> > +       import_uuid(&sb->s_uuid, c->uuid);
> > +
> >         mutex_unlock(&c->umount_mutex);
> >         return 0;
> >
> > --
> > 2.20.1
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko