linux-kernel - [PATCH] phy: ti: j721e-wiz: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210216082739.1414-1-angkery@163.com>
Date:   Tue, 16 Feb 2021 16:27:39 +0800
From:   angkery <angkery@....com>
To:     kishon@...com, vkoul@...nel.org, rikard.falkeborn@...il.com,
        rogerq@...com, yuehaibing@...wei.com, weiyongjun1@...wei.com,
        jsarha@...com
Cc:     linux-kernel@...r.kernel.org, Junlin Yang <yangjunlin@...ong.com>
Subject: [PATCH] phy: ti: j721e-wiz: add missing of_node_put

From: Junlin Yang <yangjunlin@...ong.com>

Fix OF node leaks by calling of_node_put in
for_each_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <yangjunlin@...ong.com>
---
 drivers/phy/ti/phy-j721e-wiz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index c9cfafe..8a4be1e 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -792,6 +792,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
 			dev_err(dev,
 				"%s: Reading \"reg\" from \"%s\" failed: %d\n",
 				__func__, subnode->name, ret);
+			of_node_put(subnode);
 			return ret;
 		}
 		of_property_read_u32(subnode, "cdns,num-lanes", &num_lanes);
-- 
1.9.1