linux-kernel - Re: [PATCH] Add CHARGE_NOW support to cw2015

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Feb 2021 16:30:50 +0100
From:   Tobias Schramm <t.schramm@...jaro.org>
To:     Martin Ashby <martin@...bysoft.com>,
        Sebastian Reichel <sre@...nel.org>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tobias Schramm <t.schramm@...jaro.org>
Subject: Re: [PATCH] Add CHARGE_NOW support to cw2015_battery.c

Hi Martin,

> 
> thanks for the patch. Looks good and tests fine.
> 
eh, scratch that. Didn't have my cup of morning coffee yet. The patch is 
fine as far as the code change goes. However it is missing a 
"Signed-off-by" line, certifying your authorship. git can generate that 
automagically for you with `git commit --signoff`.

>> CHARGE_NOW is expected by some user software (such as waybar)
>> instead of 'CAPACITY', in order to correctly calculate
>> remaining battery life.
>>
There needs to be a "Signed-off-by" line right here.
>> ---
>>   drivers/power/supply/cw2015_battery.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
[ ... ]
> 
> Reviewed-by: Tobias Schramm <t.schramm@...jaro.org>
Review retracted.

Please resend the patch with the "Signed-off-by" line included. Then I 
can mark it as reviewed.


Sorry for the confusion,

Tobias Schramm