linux-kernel - Re: [PATCH] ntfs: move check for valid resident attribute offset and length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YCvxtL5WYeO3ofKW@nuc10>
Date:   Tue, 16 Feb 2021 08:24:20 -0800
From:   Rustam Kovhaev <rkovhaev@...il.com>
To:     Anton Altaparmakov <anton@...era.com>
Cc:     "linux-ntfs-dev@...ts.sourceforge.net" 
        <linux-ntfs-dev@...ts.sourceforge.net>,
        LKML <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] ntfs: move check for valid resident attribute offset and
 length

On Tue, Feb 16, 2021 at 02:40:37AM +0000, Anton Altaparmakov wrote:
> Hi Rustam,
> 
> Thank you for the patch but it is not quite correct:
> 
> 1) The first delta: yes that is a good idea to add this check but the error message is incorrect.  It should say "Corrupt standard information attribute in inode." instead.
> 
> 2) The second delta: The check of the attribute list attribute needs to remain, i.e. your second delta needs to be deleted.
> 
> Please could you address both of the above comments and then resend?  Please then also add: "Acked-by: Anton Altaparmakov <anton@...era.com>" to the patch.
> 
> Thanks a lot in advance!
> 
> Best regards,
> 
> 	Anton
> 
hi Anton, thank you for the review! I'll resend the patch!