linux-kernel - Re: [PATCH] arm64 module: set plt* section addresses to 0x0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210216183808.GA24095@amazon.com>
Date:   Tue, 16 Feb 2021 18:38:08 +0000
From:   Shaoying Xu <shaoyi@...zon.com>
To:     <catalin.marinas@....com>, <will@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <fllinden@...zon.com>,
        <benh@...zon.com>, <shaoyi@...zon.com>
Subject: Re: [PATCH] arm64 module: set plt* section addresses to 0x0

So sorry about the double send because I forgot to cc the lists. Please just
ignore the first one. Thank you! 

On Tue, Feb 16, 2021 at 06:32:34PM +0000, Shaoying Xu wrote:
> These plt* and .text.ftrace_trampoline sections specified for arm64 have 
> non-zero addressses. Non-zero section addresses in a relocatable ELF would 
> confuse GDB when it tries to compute the section offsets and it ends up 
> printing wrong symbol addresses. Therefore, set them to zero, which mirrors 
> the change in commit 5d8591bc0fba ("module: set ksymtab/kcrctab* section 
> addresses to 0x0").
> 
> Reported-by: Frank van der Linden <fllinden@...zon.com>
> Signed-off-by: Shaoying Xu <shaoyi@...zon.com>
> Cc: stable@...r.kernel.org
> ---
>  arch/arm64/include/asm/module.lds.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/module.lds.h b/arch/arm64/include/asm/module.lds.h
> index 691f15af788e..810045628c66 100644
> --- a/arch/arm64/include/asm/module.lds.h
> +++ b/arch/arm64/include/asm/module.lds.h
> @@ -1,7 +1,7 @@
>  #ifdef CONFIG_ARM64_MODULE_PLTS
>  SECTIONS {
> -	.plt (NOLOAD) : { BYTE(0) }
> -	.init.plt (NOLOAD) : { BYTE(0) }
> -	.text.ftrace_trampoline (NOLOAD) : { BYTE(0) }
> +	.plt 0 (NOLOAD) : { BYTE(0) }
> +	.init.plt 0 (NOLOAD) : { BYTE(0) }
> +	.text.ftrace_trampoline 0 (NOLOAD) : { BYTE(0) }
>  }
>  #endif
> -- 
> 2.16.6
>