linux-kernel - [PATCH v5] TPM fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1613504532-4165-1-git-send-email-LinoSanfilippo@gmx.de>
Date:   Tue, 16 Feb 2021 20:42:11 +0100
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     peterhuewe@....de, jarkko@...nel.org, jgg@...pe.ca
Cc:     stefanb@...ux.vnet.ibm.com, James.Bottomley@...senpartnership.com,
        David.Laight@...LAB.COM, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, LinoSanfilippo@....de
Subject: [PATCH v5] TPM fixes

This patch fixes a reference count issue in the TPM core code.

Changes in v5
- move function tpm_add_tpm2_char_device() to tpm2-space.c and rename
it to tpm2_add_device() as requested by Jarko
- put "cc" tag before all other tags 
- ensure that the error path in tpm2_add_device() always calls 
the release() function of chip->devs as requested by Jason
- reformat a code line as suggested by David Laight

Changes in v4
- drop patch 2 (tpm: in tpm2_del_space check if ops pointer is still
valid) since James Bottomley offered a cleaner solution for this
- reimplement patch 1 to setup the /dev/tpmrm device only in case of TPM2
and avoid the installation of another action handler. This is based on a
suggestion and basic implementation done by Jason Gunthorpe.
- added tag to CC stable

Changes in v3
- drop the patch that introduces the new function tpm_chip_free()
- rework the commit messages for the patches (style, typos, etc.)
- add fixes tag to patch 2
- add James Bottomley to cc list
- add stable mailing list to cc list

Changes in v2:
- drop the patch that erroneously cleaned up after failed installation of
  an action handler in tpmm_chip_alloc() (pointed out by Jarkko Sakkinen)
- make the commit message for patch 1 more detailed
- add fixes tags and kernel logs


Lino Sanfilippo (1):
  The following sequence of operations results in a refcount warning:

 drivers/char/tpm/tpm-chip.c   | 48 +++++++++----------------------------------
 drivers/char/tpm/tpm.h        |  1 +
 drivers/char/tpm/tpm2-space.c | 48 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+), 38 deletions(-)

-- 
2.7.4