linux-kernel - Re: [PATCH 5.10 098/104] switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210216213508.GA32671@amd>
Date:   Tue, 16 Feb 2021 22:35:08 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 5.10 098/104] switchdev: mrp: Remove
 SWITCHDEV_ATTR_ID_MRP_PORT_STAT

Hi!

> From: Horatiu Vultur <horatiu.vultur@...rochip.com>
> 
> commit 059d2a1004981dce19f0127dabc1b4ec927d202a upstream.
> 
> Now that MRP started to use also SWITCHDEV_ATTR_ID_PORT_STP_STATE to
> notify HW, then SWITCHDEV_ATTR_ID_MRP_PORT_STAT is not used anywhere
> else, therefore we can remove it.

Are you sure this is suitable for 5.10 backport? Unlike mainline,
net/bridge use is not removed, so this will cause compile problem...?

pavel@amd:~/cip/krc$ grep -ri SWITCHDEV_ATTR_ID_MRP_PORT_STATE .
./include/net/switchdev.h:    SWITCHDEV_ATTR_ID_MRP_PORT_STATE,
./net/bridge/br_mrp_switchdev.c:		.id = SWITCHDEV_ATTR_ID_MRP_PORT_STATE,
pavel@amd:~/cip/krc$ e ./net/bridge/br_mrp_switchdev.c

Best regards,
								Pavel

> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -41,7 +41,6 @@ enum switchdev_attr_id {
>  	SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED,
>  	SWITCHDEV_ATTR_ID_BRIDGE_MROUTER,
>  #if IS_ENABLED(CONFIG_BRIDGE_MRP)
> -	SWITCHDEV_ATTR_ID_MRP_PORT_STATE,
>  	SWITCHDEV_ATTR_ID_MRP_PORT_ROLE,
>  #endif
>  };

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)