linux-kernel - Re: [PATCH] Staging: mt7621-pci: pci-mt7621: fixed a blank line coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs-H-FTUxSFAsbNe9Gja4f6WR2259KQpZ3q5ByP7hYnXzwyw@mail.gmail.com>
Date:   Wed, 17 Feb 2021 07:58:52 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Selvakumar Elangovan <selvakumar16197@...il.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: mt7621-pci: pci-mt7621: fixed a blank line
 coding style issue

Hi Selvakumar,

On Wed, Feb 17, 2021 at 7:53 AM Selvakumar Elangovan
<selvakumar16197@...il.com> wrote:
>
> Removed an unecessary blank line before closing brace reported by
> checkpatch.pl

Typo:

s/unecessary/unnecessary/g

>
> Signed-off-by: Selvakumar Elangovan <selvakumar16197@...il.com>
> ---
>  drivers/staging/mt7621-pci/pci-mt7621.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> index c3532bc138fb..1781c1dcf5b4 100644
> --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> @@ -521,7 +521,6 @@ static void mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
>
>                         if (slot == 1 && tmp && !tmp->enabled)
>                                 phy_power_off(tmp->phy);
> -
>                 }
>         }
>  }
> --
> 2.17.1
>

Please, also change commit short message to:

staging: mt7621-pci: fixed a blank line coding style issue

With that changes:

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@...il.com>

Best regards,
    Sergio Paracuellos