linux-kernel - Re: [PATCH 2/2] mm: Make alloc_contig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YC03Pmb6/ePK2UPn@dhcp22.suse.cz>
Date:   Wed, 17 Feb 2021 16:33:18 +0100
From:   Michal Hocko <mhocko@...e.com>
To:     Oscar Salvador <osalvador@...e.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        David Hildenbrand <david@...hat.com>,
        Muchun Song <songmuchun@...edance.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb
 pages

On Wed 17-02-21 16:27:27, Oscar Salvador wrote:
> On 2021-02-17 16:06, Michal Hocko wrote:
> > I do not follow. You have successfully isolated huge pages so why don't
> > you add that page to the migratepages list to be migrated?
> 
> It is added. Note that I pass de list (cc->migratepages) to
> isolate_or_dissolve_huge_page().
> It is done this way because we have to pass the list to isolate_huge_page()
> directly.
> That is why I jump to isolate_success_no_list instead of isolate_sucess.
> 
> I know it is subtle, but I could not come up with a better name at that
> time.

OK, I have missed that. Maybe just extend the comment. 

	/*
	 * Hugepage was succesfully isolated and on the tmigratepages
	 * list 
	 */
-- 
Michal Hocko
SUSE Labs