linux-kernel - [PATCH] cert: Add kconfig dependency for validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Feb 2021 11:50:58 -0500
From:   Eric Snowberg <eric.snowberg@...cle.com>
To:     dhowells@...hat.com, dwmw2@...radead.org
Cc:     keyrings@...r.kernel.org, linux-kernel@...r.kernel.org,
        eric.snowberg@...cle.com
Subject: [PATCH] cert: Add kconfig dependency for validate_trust

The kernel test robot reports when building with Kconfig
CONFIG_INTEGRITY_PLATFORM_KEYRING defined and 
CONFIG_SYSTEM_DATA_VERIFICATION undefined:

ld.lld: error: undefined symbol: pkcs7_validate_trust
referenced by blacklist.c:128 (certs/blacklist.c:128)
             blacklist.o:(is_key_on_revocation_list) in archive certs/built-in.a

Make CONFIG_SYSTEM_DATA_VERIFICATION a dependency for validate_trust.

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Eric Snowberg <eric.snowberg@...cle.com>
---
 certs/blacklist.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/certs/blacklist.h b/certs/blacklist.h
index 420bb7c86e07..a86f0b52a033 100644
--- a/certs/blacklist.h
+++ b/certs/blacklist.h
@@ -4,7 +4,7 @@
 
 extern const char __initconst *const blacklist_hashes[];
 
-#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING
+#if defined(CONFIG_INTEGRITY_PLATFORM_KEYRING) && defined(SYSTEM_DATA_VERIFICATION)
 #define validate_trust pkcs7_validate_trust
 #else
 static inline int validate_trust(struct pkcs7_message *pkcs7,
-- 
2.18.4