linux-kernel - Re: [PATCH v5 2/3] mm, slub: don't combine pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5289046-1dc-e90-56d0-30dd63da93a@google.com>
Date:   Wed, 17 Feb 2021 10:21:43 -0800 (PST)
From:   David Rientjes <rientjes@...gle.com>
To:     Yafang Shao <laoar.shao@...il.com>
cc:     pmladek@...e.com, willy@...radead.org,
        andriy.shevchenko@...ux.intel.com, david@...hat.com,
        linmiaohe@...wei.com, vbabka@...e.cz, cl@...ux.com,
        penberg@...nel.org, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org, rostedt@...dmis.org,
        sergey.senozhatsky@...il.com, joe@...ches.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/3] mm, slub: don't combine pr_err with INFO

On Mon, 15 Feb 2021, Yafang Shao wrote:

> It is strange to combine "pr_err" with "INFO", so let's remove the
> prefix completely.
> This patch is motivated by David's comment[1].
> 
> - before the patch
> [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head)
> 
> - after the patch
> [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head)
> 
> [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a762@redhat.com/#t
> 
> Suggested-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
> Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: David Hildenbrand <david@...hat.com>
> Cc: Matthew Wilcox <willy@...radead.org>

Acked-by: David Rientjes <rientjes@...gle.com>