linux-kernel - Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210217210653.GA2752472@robh.at.kernel.org>
Date:   Wed, 17 Feb 2021 15:06:53 -0600
From:   Rob Herring <robh@...nel.org>
To:     Nava kishore Manne <navam@...inx.com>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        git <git@...inx.com>,
        Appana Durga Kedareswara Rao <appanad@...inx.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "chinnikishore369@...il.com" <chinnikishore369@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "trix@...hat.com" <trix@...hat.com>,
        Michal Simek <michals@...inx.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal
 fpga manager

On Fri, Feb 12, 2021 at 06:13:33AM +0000, Nava kishore Manne wrote:
> Hi Rob,
> 
> Please find my response inline.
> 
> > -----Original Message-----
> > From: Rob Herring <robh@...nel.org>
> > Sent: Thursday, February 11, 2021 8:26 PM
> > To: Nava kishore Manne <navam@...inx.com>
> > Cc: linux-arm-kernel@...ts.infradead.org; mdf@...nel.org; linux-
> > fpga@...r.kernel.org; git <git@...inx.com>; Appana Durga Kedareswara Rao
> > <appanad@...inx.com>; devicetree@...r.kernel.org; robh+dt@...nel.org;
> > chinnikishore369@...il.com; linux-kernel@...r.kernel.org;
> > trix@...hat.com; Michal Simek <michals@...inx.com>
> > Subject: Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> > manager
> > 
> > On Thu, 11 Feb 2021 11:35:31 +0530, Nava kishore Manne wrote:
> > > From: Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>
> > >
> > > This patch adds binding doc for versal fpga manager driver.
> > >
> > > Signed-off-by: Nava kishore Manne <nava.manne@...inx.com>
> > > Signed-off-by: Appana Durga Kedareswara rao
> > > <appana.durga.rao@...inx.com>
> > > ---
> > > Changes for v2:
> > >                 -Fixed file format and syntax issues.
> > >
> > >  .../bindings/fpga/xlnx,versal-fpga.yaml       | 33 +++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> > >
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:12:14:
> > [warning] too many spaces after colon (colons)
> > ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:20:9:
> > [warning] wrong indentation: expected 10 but found 8 (indentation)
> > 
> > dtschema/dtc warnings/errors:
> > 
> > See https://patchwork.ozlabs.org/patch/1439305
> > 
> > This check can fail if there are any dependencies. The base for a patch series
> > is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above error(s),
> > then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> 
> Initially, I couldn't see any issue when I run.
> After installing yamllint and with upgraded dt-schema, I am able to reproduce the above pointed issues.
> Is there any prerequisite(Other than yamllint) I need to follow to run dt-schema?

No, just keeping dtschema up to date.

Rob