linux-kernel - Re: output: was: Re: [PATCH v4] printk: Userspace format enumeration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YC2Ja3DjKd/PFYKg@chrisdown.name>
Date:   Wed, 17 Feb 2021 21:23:55 +0000
From:   Chris Down <chris@...isdown.name>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Petr Mladek <pmladek@...e.com>, linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        John Ogness <john.ogness@...utronix.de>,
        Johannes Weiner <hannes@...xchg.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>, kernel-team@...com
Subject: Re: output: was: Re: [PATCH v4] printk: Userspace format enumeration
 support

Steven Rostedt writes:
>OK, now do the same in C. "%q" "and I guess that "f" in the print statement
>in python (but I don't know for sure) does some magic with converting the
>"\n" and such.
>
>I agree with Petr on this. Print the format itself, and not what is
>converted. It's much easier to convert "\t" and such to what they mean,
>than to go the other way around.

To be clear, you're advocating for escaping tabs/newlines/etc on the kernel 
side, right?

That seems to be implied by your first paragraph, but "print the format itself 
and not what is converted" sounds like the opposite of that to me. I assume 
your meaning is "escape the format, don't print it raw", which is what Petr was 
also advocating for? :-)