linux-kernel - Re: [PATCH v6 20/34] xlink-core: Add xlink core driver xLink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210217232939.GD154917@linux.intel.com>
Date:   Wed, 17 Feb 2021 15:29:39 -0800
From:   mark gross <mgross@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     mgross@...ux.intel.com, markgross@...nel.org, arnd@...db.de,
        bp@...e.de, damien.lemoal@....com, dragan.cvetic@...inx.com,
        gregkh@...uxfoundation.org, corbet@....net,
        palmerdabbelt@...gle.com, paul.walmsley@...ive.com,
        peng.fan@....com, robh+dt@...nel.org, shawnguo@...nel.org,
        jassisinghbrar@...il.com, linux-kernel@...r.kernel.org,
        Seamus Kelly <seamus.kelly@...el.com>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v6 20/34] xlink-core: Add xlink core driver xLink

On Sun, Feb 14, 2021 at 09:52:51AM -0800, Randy Dunlap wrote:
> On 2/12/21 2:22 PM, mgross@...ux.intel.com wrote:
> > diff --git a/drivers/misc/xlink-core/Kconfig b/drivers/misc/xlink-core/Kconfig
> > new file mode 100644
> > index 000000000000..a0ceb0b48219
> > --- /dev/null
> > +++ b/drivers/misc/xlink-core/Kconfig
> > @@ -0,0 +1,33 @@
> > +config XLINK_CORE
> > +	tristate "Support for XLINK CORE"
> > +	depends on ((XLINK_PCIE_RH_DRIVER || XBAY_XLINK_PCIE_RH_DRIVER) || (XLINK_LOCAL_HOST && (XLINK_PCIE_LH_DRIVER || XBAY_XLINK_PCIE_RH_DRIVER)))
> 
> -ELINETOOLONG. Use '\' for line continuation in Kconfig files.
fixed

> 
> > +	help
> > +	  XLINK CORE enables the communication/control subsystem.
> > +
> > +	  If unsure, say N.
> > +
> > +	  To compile this driver as a module, choose M here: the
> > +	  module will be called xlink.ko.
> > +
> > +config XLINK_LOCAL_HOST
> > +	tristate "Support for XLINK LOCAL HOST"
> > +	depends on XLINK_IPC
> > +	help
> > +	  XLINK LOCAL HOST enables local host functionality for
> > +	  the communication/control Sub-System.
> > +
> > +	  Enable this config when building the kernel for the Intel Vision
> > +	  Processing Unit (VPU) Local Host core.
> > +
> > +	  If building for a Remote Host kernel, say N.
> > +
> > +config XLINK_PSS
> > +	tristate "Support for XLINK PSS (Pre-Silicon Solution)"
> > +	depends on XLINK_LOCAL_HOST
> > +	help
> > +	  XLINK PSS enables the communication/control subsystem on a PSS platform.
> > +
> > +	  Enable this config when building the kernel for the Intel Vision
> > +	  Processing Unit (VPU) in a simulated env.
> 
> Please s/env/environment/.
fixed

I have the update qued up and I'll post v7 rebased when the merge window closes

--mark

> 
> > +
> > +	  If building for a VPU silicon, say N.
> 
> 
> -- 
> ~Randy
>