linux-kernel - Re: [PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d93ec4c-4cb9-c3c8-5b73-ae00c4fa9435@oracle.com>
Date:   Thu, 18 Feb 2021 14:38:18 -0800
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Matthew Wilcox <willy@...radead.org>,
        Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and
 huge_pmd_share()

On 2/18/21 2:27 PM, Peter Xu wrote:
> On Thu, Feb 18, 2021 at 02:13:52PM -0800, Mike Kravetz wrote:
>> On 2/18/21 1:54 PM, Peter Xu wrote:
>>> It is a preparation work to be able to behave differently in the per
>>> architecture huge_pte_alloc() according to different VMA attributes.
>>
>>> diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c
>>> index ad4b42f04988..97e0824fdbe7 100644
>>> --- a/arch/sparc/mm/hugetlbpage.c
>>> +++ b/arch/sparc/mm/hugetlbpage.c
>>> @@ -280,6 +280,7 @@ unsigned long pmd_leaf_size(pmd_t pmd) { return 1UL << tte_to_shift(*(pte_t *)&p
>>>  unsigned long pte_leaf_size(pte_t pte) { return 1UL << tte_to_shift(pte); }
>>>  
>>>  pte_t *huge_pte_alloc(struct mm_struct *mm,
>>> +pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma,
>>>  			unsigned long addr, unsigned long sz)
>>>  {
>>>  	pgd_t *pgd;
>>
>> Didn't kernel test robot report this build error on the first patch series?
> 
> That seems to be irrelevant of this series:
> 
>   arch/sparc/mm/hugetlbpage.c:269:22: error: 'huge_tte_to_size' defined but not used [-Werror=unused-function]
> 
> Thanks,

I thought the error was caused by not deleting the line

	pte_t *huge_pte_alloc(struct mm_struct *mm,

when adding

	pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma,

as above.
-- 
Mike Kravetz