linux-kernel - Re: [PATCH] staging: comedi: cast to (void _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YC4S5Pxw341zw9DL@kroah.com>
Date:   Thu, 18 Feb 2021 08:10:28 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Atul Gopinathan <atulgopinathan@...il.com>
Cc:     abbotti@....co.uk, hsweeten@...ionengravers.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: cast to (void __user *)

On Thu, Feb 18, 2021 at 11:58:40AM +0530, Atul Gopinathan wrote:
> Resolve the following sparse warning:
> drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging//comedi/comedi_fops.c:2983:41:    expected void [noderef] <asn:1> *uptr
> drivers/staging//comedi/comedi_fops.c:2983:41:    got unsigned int *chanlist
> 
> cmd->chanlist is of type (unsigned int *) as defined in
> "struct comedi_cmd" in file drivers/staging/comedi/comedi.h
> 
> The function "ptr_to_compat()" expects argument of type
> (void __user *) as defined in include/linux/compat.h
> 
> Signed-off-by: Atul Gopinathan <atulgopinathan@...il.com>
> ---
>  drivers/staging/comedi/comedi_fops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Is this different from your previous patch:
	https://lore.kernel.org/r/20210217165907.9777-1-atulgopinathan@gmail.com

if so, you might need a better subject line here, and for that one, as
they look alike at a quick glance.

Which one goes first?

Can you resend both of these as a patch series with better subjects as a
v2 patch set?

thanks,

greg k-h