linux-kernel - Re: [PATCH v5 1/8] smp: Run functions concurrently in smp_call_function_many

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210218080929.GA335524@infradead.org>
Date:   Thu, 18 Feb 2021 08:09:29 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Nadav Amit <nadav.amit@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Nadav Amit <namit@...are.com>, Rik van Riel <riel@...riel.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH v5 1/8] smp: Run functions concurrently in
 smp_call_function_many_cond()

On Tue, Feb 09, 2021 at 02:16:46PM -0800, Nadav Amit wrote:
> +/*
> + * Flags to be used as scf_flags argument of smp_call_function_many_cond().
> + */
> +#define SCF_WAIT	(1U << 0)	/* Wait until function execution completed */
> +#define SCF_RUN_LOCAL	(1U << 1)	/* Run also locally if local cpu is set in cpumask */

Can you move the comments on top of the defines to avoid the crazy
long lines?

> +	if (cpu_online(this_cpu) && !oops_in_progress && !early_boot_irqs_disabled)

Another pointlessly overly long line, with various more following.

>  EXPORT_SYMBOL(on_each_cpu_cond_mask);

This isn't used by any modular code, so maybe throw in a patch to drop
the export?