linux-kernel - Re: [PATCH] irqdomain: remove debugfs_file from struct irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eehdpx05.wl-maz@kernel.org>
Date:   Thu, 18 Feb 2021 09:04:42 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Michael Walle <michael@...le.cc>, linux-kernel@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

On Thu, 18 Feb 2021 08:54:00 +0000,
Greg KH <gregkh@...uxfoundation.org> wrote:

[...]

> > > Wow, wait, you are removing a debugfs file _before_ debugfs is even
> > > initialized?  Didn't expect that, ok, let me go try this again...
> > 
> > Yeah, that's a poor man's rename (file being deleted and re-created).
> 
> True, but that's not happening here, right?  Some driver is being
> initialized and creates a debugfs file, and then decides to unload so it
> removes the debugfs file?

No, that's not what is happening.

The irqchip driver starts, creates an irqdomain. File gets created, at
least in theory (it fails because debugfs isn't ready, but that's not
the issue).

It then changes an attribute to the domain (the so-called bus_token),
which gets reflected in the domain name to avoid aliasing.
Delete/create follows.

> Why was it trying to create the file in the first place if it didn't
> properly bind to the hardware?

See above. We encode properties of the domain in the filename, and
reflect the change of these properties as they happen.

	M.

-- 
Without deviation from the norm, progress is not possible.