linux-kernel - Re: [PATCH 3/3] Input: applespi: Add trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Feb 2021 08:18:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ronald Tschalär <ronald@...ovation.ch>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     kbuild-all@...ts.01.org,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
        Lee Jones <lee.jones@...aro.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Input: applespi: Add trace_event module param for
 early tracing.

Hi "Ronald,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on input/next]
[also build test ERROR on v5.11 next-20210217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ronald-Tschal-r/Input-applespi-Don-t-wait-for-responses-to-commands-indefinitely/20210218-032205
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: i386-randconfig-s001-20210217 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://github.com/0day-ci/linux/commit/838cd23e96675132bdd30878d1b24a59b8a534e1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ronald-Tschal-r/Input-applespi-Don-t-wait-for-responses-to-commands-indefinitely/20210218-032205
        git checkout 838cd23e96675132bdd30878d1b24a59b8a534e1
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/input/keyboard/applespi.o: in function `applespi_enable_early_event_tracing':
>> drivers/input/keyboard/applespi.c:1666: undefined reference to `trace_set_clr_event'


vim +1666 drivers/input/keyboard/applespi.c

  1653	
  1654	static void applespi_enable_early_event_tracing(struct device *dev)
  1655	{
  1656		char *buf, *event;
  1657		int sts;
  1658	
  1659		if (trace_event && trace_event[0]) {
  1660			buf = kstrdup(trace_event, GFP_KERNEL);
  1661			if (!buf)
  1662				return;
  1663	
  1664			while ((event = strsep(&buf, ","))) {
  1665				if (event[0]) {
> 1666					sts = trace_set_clr_event("applespi", event, 1);
  1667					if (sts)
  1668						dev_warn(dev,
  1669							 "Error setting trace event '%s': %d\n",
  1670							 event, sts);
  1671				}
  1672			}
  1673	
  1674			kfree(buf);
  1675		}
  1676	}
  1677	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29308 bytes)