linux-kernel - Re: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8350 CPUfreq compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210218124457.GW2774@vkoul-mobl.Dlink>
Date:   Thu, 18 Feb 2021 18:14:57 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Rob Herring <robh+dt@...nel.org>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8350
 CPUfreq compatible

On 17-02-21, 10:19, Viresh Kumar wrote:
> On 16-02-21, 16:42, Vinod Koul wrote:
> > Add the CPUfreq compatible for SM8350 SoC along with note for using the
> > specific compatible for SoCs
> > 
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> >  Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt
> > index 9299028ee712..3eb3cee59d79 100644
> > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt
> > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt
> > @@ -8,7 +8,9 @@ Properties:
> >  - compatible
> >  	Usage:		required
> >  	Value type:	<string>
> > -	Definition:	must be "qcom,cpufreq-hw" or "qcom,cpufreq-epss".
> > +	Definition:	must be "qcom,cpufreq-hw" or "qcom,cpufreq-epss"
> > +			along with SoC specific compatible:
> > +			  "qcom,sm8350-cpufreq-epss", "qcom,cpufreq-epss"
> 
> And why is SoC specific compatible required here ? Is the implementation on
> sm8350 any different than the ones using "qcom,cpufreq-epss" compatible ?
> 
> FWIW, the same compatible string must be reused until the time there is
> difference in the hardware. The compatible string must be considered as a marker
> for a particular version of the hardware.

Rob has indicated that we should use a SoC specific compatible and I
agree with that. We are using both soc and generic one here and driver
will be loaded for generic one.

Thanks
-- 
~Vinod