linux-kernel - Re: [PATCH v4 1/3] dt-bindings:drm/bridge:anx7625:add vendor define flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210218032941.GA2891@zhaomy-pc>
Date:   Thu, 18 Feb 2021 11:29:41 +0800
From:   Xin Ji <xji@...logixsemi.com>
To:     Rob Herring <robh@...nel.org>
Cc:     David Airlie <airlied@...ux.ie>,
        Nicolas Boichat <drinkcat@...gle.com>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Daniel Vetter <daniel@...ll.ch>,
        Sam Ravnborg <sam@...nborg.org>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Maxime Ripard <mripard@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Ricardo Cañuelo 
        <ricardo.canuelo@...labora.com>, dri-devel@...ts.freedesktop.org,
        devicetree@...r.kernel.org, Bernie Liang <bliang@...logixsemi.com>,
        Sheng Pan <span@...logixsemi.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings:drm/bridge:anx7625:add vendor define
 flags

Hi Rob Herring, thanks for the comments.

On Tue, Feb 09, 2021 at 01:30:10PM -0600, Rob Herring wrote:
> On Thu, Jan 28, 2021 at 11:08:26AM +0800, Xin Ji wrote:
> > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support
> > flag and DP tx lane0 and lane1 swing register array define.
> > 
> > Signed-off-by: Xin Ji <xji@...logixsemi.com>
> > ---
> >  .../bindings/display/bridge/analogix,anx7625.yaml  | 54 +++++++++++++++++++++-
> >  1 file changed, 53 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index c789784..048deec 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -34,6 +34,24 @@ properties:
> >      description: used for reset chip control, RESET_N pin B7.
> >      maxItems: 1
> >  
> > +  analogix,lane0-swing:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    maxItems: 20
> > +    description:
> > +      an array of swing register setting for DP tx lane0 PHY, please don't
> > +      add this property, or contact vendor.
> > +
> > +  analogix,lane1-swing:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    maxItems: 20
> > +    description:
> > +      an array of swing register setting for DP tx lane1 PHY, please don't
> > +      add this property, or contact vendor.
> > +
> > +  analogix,hdcp-support:
> > +    type: boolean
> > +    description: indicate the DP tx HDCP support or not.
> 
> Please show the new properties in the example.
OK, I'll add it in the example.
> 
> > +
> >    ports:
> >      $ref: /schemas/graph.yaml#/properties/ports
> >  
> > @@ -41,13 +59,45 @@ properties:
> >        port@0:
> >          $ref: /schemas/graph.yaml#/properties/port
> >          description:
> > -          Video port for MIPI DSI input.
> > +          Video port for MIPI input.
> > +
> > +        properties:
> > +          endpoint:
> > +            type: object
> > +            additionalProperties: false
> > +
> > +            # Properties described in
> > +            # Documentation/devicetree/bindings/media/video-interfaces.txt
> 
> Now video-interfaces.yaml which should have a $ref here. It's currently 
> in media tree and linux-next. Follow the examples there. You'll also 
> have to wait for 5.12-rc1 to apply to drm-misc.
OK.
> 
> > +            properties:
> > +              remote-endpoint: true
> > +              bus-type: true
> > +              data-lanes: true
> > +
> > +            required:
> > +              - remote-endpoint
> > +
> > +        required:
> > +          - endpoint
> > +
> >  
> >        port@1:
> >          $ref: /schemas/graph.yaml#/properties/port
> >          description:
> >            Video port for panel or connector.
> >  
> > +        properties:
> > +          endpoint:
> > +            type: object
> > +            additionalProperties: false
> > +
> > +            # Properties described in
> > +            # Documentation/devicetree/bindings/media/video-interfaces.txt
> > +            properties:
> > +              remote-endpoint: true
> > +
> > +            required:
> > +              - remote-endpoint
> > +
> >      required:
> >        - port@0
> >        - port@1
> > @@ -81,6 +131,8 @@ examples:
> >                      reg = <0>;
> >                      anx7625_in: endpoint {
> >                          remote-endpoint = <&mipi_dsi>;
> > +                        bus-type = <5>;
> > +                        data-lanes = <0 1 2 3>;
> >                      };
> >                  };
> >  
> > -- 
> > 2.7.4
> >