linux-kernel - Re: [PATCH net-next] net: mscc: Fix MRP switchdev driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Feb 2021 20:38:18 +0100
From:   Horatiu Vultur <horatiu.vultur@...rochip.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: mscc: Fix MRP switchdev driver

The 02/18/2021 13:17, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 

Hi Vladimir,

> Hi Horatiu,
> 
> On Thu, Feb 18, 2021 at 12:47:26PM +0100, Horatiu Vultur wrote:
> > This patch fixes the ocelot MRP switchdev driver such that also DSA
> > driver can use these functions. Before the driver presumed that the
> > net_device uses a 'struct ocelot_port_private' as priv which was wrong.
> >
> > The only reason for using ocelot_port_private was to access the
> > net_device, but this can be passed as an argument because we already
> > have this information. Therefore update the functions to have also the
> > net_device parameter.
> >
> > Fixes: a026c50b599fa ("net: dsa: felix: Add support for MRP")
> > Fixes: d8ea7ff3995ea ("net: mscc: ocelot: Add support for MRP")
> > Reported-by: Vladimir Oltean <vladimir.oltean@....com>
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> >
> > ---
> 
> Do you mind if we drop this patch for now (the net-next pull request was
> already sent) and I will ensure that the MRP assist for Felix DSA works
> properly when I find the time to compile your mrp/cfp user space
> packages and give them a try?

Yes is perfectly fine for me.

> 
> There are more issues to be fixed than your patch addresses. For
> example, MRP will only work with the NPI-based tagging protocol,
> somebody needs to reject MRP objects when ocelot-8021q is in use.
> I think it's better for someone who has access to a DSA setup to ensure
> that the driver is in a reasonable state.

I agree on that. If this will require any changes to the switchdev part,
I would definitely like to test those.

> 
> Sorry for not reviewing the MRP patches in time.

-- 
/Horatiu