linux-kernel - Re: [PATCH net-next v2 0/2] net: phy: at803x: paging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15a6833c0db85fc3871a1d926d6636d6@walle.cc>
Date:   Thu, 18 Feb 2021 20:46:10 +0100
From:   Michael Walle <michael@...le.cc>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v2 0/2] net: phy: at803x: paging support

Am 2021-02-18 20:26, schrieb Vladimir Oltean:
> On Thu, Feb 18, 2021 at 07:52:38PM +0100, Michael Walle wrote:
>> Add paging support to the QCA AR8031/33 PHY. This will be needed if we
>> add support for the .config_inband_aneg callback, see series [1].
>> 
>> The driver itself already accesses the fiber page (without proper 
>> locking).
>> The former version of this patchset converted the access to
>> phy_read_paged(), but Vladimir Oltean mentioned that it is dead code.
>> Therefore, the second patch will just remove it.
>> 
>> changes since v1:
>>  - second patch will remove at803x_aneg_done() altogether
> 
> I'm pretty sure net-next is closed now, since David sent the pull
> request, and I didn't come to a conclusion yet regarding the final
> form of the phy_config_inband_aneg method either.

Yeah I wasn't sure. http://vger.kernel.org/~davem/net-next.html says
it is still open. But anyway, if not, I'll resend the patch after
the merge window. I've also thought about splitting it into two
individual patches, because they aren't dependent on each other
anymore.

We'll need the page support anyway, even if phy_config_inband_aneg
will change. Ok granted, the cover letter might be misleading then.

-michael