linux-kernel - Re: [PATCH] Staging: comedi: Replaced strlcpy to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43b0f966-9d88-3c92-28ce-6dfce755a1be@mev.co.uk>
Date:   Thu, 18 Feb 2021 16:45:30 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     chakravarthikulkarni <chakravarthikulkarni2021@...il.com>
Cc:     H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Xin Tan <tanxin.ctf@...il.com>,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Michel Lespinasse <walken@...gle.com>,
        B K Karthik <bkkarthik@...u.pes.edu>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: Replaced strlcpy to strscpy

On 18/02/2021 14:31, chakravarthikulkarni wrote:
> Warning found by checkpath.pl script.
> 
> Signed-off-by: chakravarthikulkarni <chakravarthikulkarni2021@...il.com>
> ---
>  drivers/staging/comedi/comedi_fops.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 80d74cce2a01..df77b6bf5c64 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -939,8 +939,8 @@ static int do_devinfo_ioctl(struct comedi_device *dev,
>  	/* fill devinfo structure */
>  	devinfo.version_code = COMEDI_VERSION_CODE;
>  	devinfo.n_subdevs = dev->n_subdevices;
> -	strlcpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
> -	strlcpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
> +	strscpy(devinfo.driver_name, dev->driver->driver_name, COMEDI_NAMELEN);
> +	strscpy(devinfo.board_name, dev->board_name, COMEDI_NAMELEN);
>  
>  	s = comedi_file_read_subdevice(file);
>  	if (s)
> 

Thanks, but you are too late.  It has already been fixed in linux-next.

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-