linux-kernel - Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210219070139.GP2222@kadam>
Date:   Fri, 19 Feb 2021 10:01:40 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kurt Manucredo <fuzzybritches@...tonmail.com>
Cc:     gregkh@...uxfoundation.org, ross.schm.dev@...il.com,
        straube.linux@...il.com, d.straghkov@...ras.ru, tiwai@...e.de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl
 conform

On Thu, Feb 18, 2021 at 07:50:27PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches@...tonmail.com>
> ---
> 
> The preferred coding style is:
> 	if (!StaAddr)
> 	return;

Above the Signed-off-by line.  Also indenting is wrong.  And it's hard
to understand what you're saying.

> 
> thank you mr. dan carpenter

You're welcome.  (These sorts of comments do go below the --- cut off
line so that's fine.)

regards,
dan carpenter