linux-kernel - Re: [PATCH v1] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Feb 2021 01:06:24 -0800
From:   Badhri Jagan Sridharan <badhri@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Kyle Tso <kyletso@...gle.com>, USB <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V
 before toggling

Done. Just sent out the following patch and CCed stable@...r.kernel.org as well.

[PATCH v2] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling

Thanks,
Badhri


On Thu, Feb 18, 2021 at 2:42 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Thu, Feb 18, 2021 at 02:38:45AM -0800, Badhri Jagan Sridharan wrote:
> > Hi Greg,
> >
> > This patch is a bug fix for the following patch which was introduced in 5.11.
> >
> > commit f321a02caebdd0c56e167610cda2fa148cd96e8b
> > Author: Badhri Jagan Sridharan <badhri@...gle.com>
> > Date:   Wed Oct 28 23:31:35 2020 -0700
> >
> >     usb: typec: tcpm: Implement enabling Auto Discharge disconnect support
> >
> >     TCPCI spec allows TCPC hardware to autonomously discharge the vbus
> >     capacitance upon disconnect. The expectation is that the TCPM enables
> >     AutoDischargeDisconnect while entering SNK/SRC_ATTACHED states. Hardware
> >     then automously discharges vbus when the vbus falls below a certain
> >     threshold i.e. VBUS_SINK_DISCONNECT_THRESHOLD.
> >
> >     Apart from enabling the vbus discharge circuit, AutoDischargeDisconnect
> >     is also used a flag to move TCPCI based TCPC implementations into
> >     Attached.Snk/Attached.Src state as mentioned in
> >     Figure 4-15. TCPC State Diagram before a Connection of the
> >     USB Type-C Port Controller Interface Specification.
> >     In such TCPC implementations, setting AutoDischargeDisconnect would
> >     prevent TCPC into entering "Connection_Invalid" state as well.
> >
> >     Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>
> >     Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> >     Link: https://lore.kernel.org/r/20201029063138.1429760-8-badhri@google.com
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
> Great, then can you resend the patch and add a proper Fixes: tag, along
> with a cc: stable as well?
>
> thanks,
>
> greg k-h