linux-kernel - Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3wJDAA9X6se4EvSpoQTWyxdyeVt+8vfCCbTpe+Zqixew@mail.gmail.com>
Date:   Fri, 19 Feb 2021 11:12:31 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Jason Wang <jasowang@...hat.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        virtualization@...ts.linux-foundation.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Anders Roxell <anders.roxell@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

On Fri, Feb 19, 2021 at 9:45 AM Jason Wang <jasowang@...hat.com> wrote:
>
> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
> lot of confusion. E.g it may break various default configs which want
> virtio devices.
>
> So this patch fixes this by hide the prompot and document the
> dependency.
>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Anders Roxell <anders.roxell@...aro.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Acked-by: Arnd Bergmann <arnd@...db.de>

Note that this effectively makes VIRTIO_PCI_MODERN and VIRTIO_PCI
synonyms, so git goes back to not being able to have VIRTIO_PCI_MODERN
by itself, but it seems that this is ok because the legacy part was already
split out.

        Arnd