linux-kernel - Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210219112155.GL19207@duo.ucw.cz>
Date:   Fri, 19 Feb 2021 12:21:55 +0100
From:   Pavel Machek <pavel@....cz>
To:     "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
Cc:     Andreas Eberlein <foodeas@...erlein.de>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with
 newer firmware

> >   MODULE_DEVICE_TABLE(dmi, apu_led_dmi_table);
> > @@ -173,7 +182,7 @@ static int __init apu_led_init(void)
> >   	int err;
> >   	if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") &&
> > -	      dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> > +	      (dmi_match(DMI_PRODUCT_NAME, "APU") || dmi_match(DMI_PRODUCT_NAME, "apu1")))) {
> >   		pr_err("No PC Engines APUv1 board detected. For APUv2,3 support, enable CONFIG_PCENGINES_APU2\n");
> >   		return -ENODEV;
> >   	}
> > 
> 
> Looks good to me. But don't dare giving official ack, since I don't
> have an apu1 board for testing.
> 
> Is Alan Mizrahi (original author) still here ?

People are usually not that careful with thier acks.

Applied, thanks.

BR,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)