linux-kernel - Re: [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210219134000.GA25666@amrit>
Date:   Fri, 19 Feb 2021 19:10:03 +0530
From:   Amrit Khera <amritkhera98@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Amrit Khera <amritkhera98@...il.com>, arve@...roid.com,
        tkjos@...roid.com, maco@...roid.com, joel@...lfernandes.org,
        christian@...uner.io, hridya@...gle.com, surenb@...gle.com,
        dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: android: Fix const keyword style issue in
 ashmem.c

On Fri, Feb 19, 2021 at 01:12:49PM +0100, Greg KH wrote:
> On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote:
> > This change fixes a checkpatch warning for "struct file_operations
> > should normally be const".
> > 
> > Signed-off-by: Amrit Khera <amritkhera98@...il.com>
> > ---
> > Changes in v2:
> >  - Wrapped the commit description
> >  - Build tested
> 
> If you tested it, what changed in the diff itself?  Looks the same to
> me...
> 

After further investigating I found that the particular kernel module
was not set in the config file. This did not build it when I built the
kernel. This was making me think that the module was building correctly.

After updating the config, the build indeed breaks. The reason is that
the const keyword cannot be applied here without changing the structure
and flow of the code as the particular variable is later being set in a
condition. Hence, I will be dropping this path for now.

Apologies for the inconvenience caused and thank you for the prompt
replies.

Best Regards,
Amrit Khera