linux-kernel - AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Feb 2021 14:09:03 +0000
From:   Sven Schuchmann <schuchmann@...leissheimer.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity
 from DT

Hello Andy,

> Von: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Gesendet: Freitag, 19. Februar 2021 14:56
> An: Sven Schuchmann <schuchmann@...leissheimer.de>
> Cc: Pavel Machek <pavel@....cz>; Dan Murphy <dmurphy@...com>; linux-leds@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Betreff: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT
> 
> > > > > Can you or Dan submit patch getting the regulator support to work? If
> > > > > not, I guess we should remove the regulator support after all.
> > > >
> > > > To be true I am fairly new to the kernel and have no idea
> > > > how to test this. So no, I don't want provide a patch (except
> > > > for removing), sorry.
> > >
> > > No problem. It seems Andy submitted series for this.
> > >
> >
> > To me it seems that patches from Andy don't make
> > the regulator work. Maybe I am wrong?
> 
> I;m not sure I understand this correctly. Do you mean that my patches broke
> something? Which one explicitly and what is broken?

No, your patches do not break something (as far as I can see).
Pavel asked for a patch to fix the regulator. The regulator
at this time is only initialized but never used in the lp50xx.
I told him (see above) that I cannot provide a patch which
fixes this. He answered that you fixed this in your series,
but to me it doesn't seem so.
or did you fix the regulator usage in your patch series?

Best Regards,

   Sven